feat(usvg): add warning when parsing malformed paths - #1011
Merged
Conversation
Its-Just-Nans
changed the title
Collaborator
|
I've removed the warning from transform parsing, because we already print warnings for nodes attributes that fail to parse, so it's being printed twice: resvg/crates/usvg/src/parser/svgtree/mod.rs Lines 302 to 308 in 67c2c65 But the one for paths looks fine to me (those are just parsed as raw strings so they aren't detected earlier. |
LaurenzV
changed the title
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #938